vanzin commented on a change in pull request #24305: [SPARK-27294][SS] Add multi-cluster Kafka delegation token URL: https://github.com/apache/spark/pull/24305#discussion_r276341752
########## File path: external/kafka-0-10-token-provider/src/main/scala/org/apache/spark/kafka010/KafkaTokenSparkConf.scala ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.kafka010 + +import org.apache.kafka.common.security.auth.SecurityProtocol.SASL_SSL + +import org.apache.spark.SparkConf +import org.apache.spark.internal.Logging +import org.apache.spark.internal.config.Kafka + +private[spark] case class KafkaTokenClusterConf( + identifier: String, + bootstrapServers: String, + securityProtocol: String, + kerberosServiceName: String, + trustStoreLocation: Option[String], + trustStorePassword: Option[String], + keyStoreLocation: Option[String], + keyStorePassword: Option[String], + keyPassword: Option[String], + tokenMechanism: String) { + override def toString: String = s"KafkaTokenClusterConf{" + s"identifier=$identifier, " + + s"bootstrapServers=$bootstrapServers, " + s"securityProtocol=$securityProtocol, " + + s"kerberosServiceName=$kerberosServiceName, " + + s"trustStoreLocation=$trustStoreLocation, " + + s"trustStorePassword=${trustStorePassword.map(_ => "xxx")}, " + + s"keyStoreLocation=$keyStoreLocation, " + s"keyStorePassword=${keyStorePassword.map(_ => "xxx")}, " + + s"keyPassword=${keyPassword.map(_ => "xxx")}, " + + s"tokenMechanism=$tokenMechanism}" +} + +private[spark] class KafkaTokenSparkConf(sparkConf: SparkConf) extends Logging { + def getClusterIdentifiers(): Array[String] = { + val result = sparkConf.get(Kafka.CLUSTERS) match { Review comment: The only way I can see to avoid the user providing this information in their application is to have it in the configuration. Or to have Kafka figure it out by itself. I prefer not to have users change their application, because that *will* get messy. Changing a configuration file is much easier (and can be automated). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
