mengxr commented on a change in pull request #24387: [SPARK-27473][SQL][WIP]
Support filter push down for status fields in binary file data source
URL: https://github.com/apache/spark/pull/24387#discussion_r276433241
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormat.scala
##########
@@ -93,6 +98,68 @@ class BinaryFileFormat extends FileFormat with
DataSourceRegister {
val pathGlobPattern = binaryFileSourceOptions.pathGlobFilter
+ val modificationTimeFilters = new mutable.ListBuffer[Long => Boolean]
+ val lengthFilters = new mutable.ListBuffer[Long => Boolean]
+
+ def parseFilter(filter: Filter): Unit = {
Review comment:
I would call it `createFilterFunctions` and let it return `Seq[FileStatus =>
Boolean]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
