pengbo commented on issue #24389: [SPARK-27482][SQL][Web UI]: Show 
BroadcastHashJoinExec numOutputRows statistics info on SparkSQL UI page
URL: https://github.com/apache/spark/pull/24389#issuecomment-484346135
 
 
   > I agree with the use case, but the implementation is too hacky. We need a 
general approach to propagate the statistics from logical plan to physical plan.
   
   Thanks for your comments. 
   
   How about:
   1. Add `stats` field and getter/setter in `SparkPlanStats` (trait of 
`SparkPlan`)
   2. Add `setPlanProperty(plan, candidate)` before `collectPlaceholders` in 
`QueryPlanner.plan` which is override by `SparkPlanner` to set the `stats` 
value in `candidate: SparkPlan` from `plan: LogicalPlan`
   
   Your feedback is appreciated.  @cloud-fan @dongjoon-hyun 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to