mengxr commented on a change in pull request #24387: [SPARK-27473][SQL] Support filter push down for status fields in binary file data source URL: https://github.com/apache/spark/pull/24387#discussion_r276512314
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormatSuite.scala ########## @@ -39,6 +41,12 @@ class BinaryFileFormatSuite extends QueryTest with SharedSQLContext with SQLTest private var fs: FileSystem = _ + private var file1Status: FileStatus = _ Review comment: If we only unit test `buildReader`, we don't need to share those objects across tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
