viirya commented on a change in pull request #24344: [SPARK-27440][SQL]
Optimize uncorrelated predicate subquery
URL: https://github.com/apache/spark/pull/24344#discussion_r276573095
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
##########
@@ -95,7 +95,8 @@ object RewritePredicateSubquery extends Rule[LogicalPlan]
with PredicateHelper {
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
case Filter(condition, child) =>
val (withSubquery, withoutSubquery) =
-
splitConjunctivePredicates(condition).partition(SubqueryExpression.hasInOrExistsSubquery)
+ splitConjunctivePredicates(condition)
+ .partition(SubqueryExpression.hasCorrelatedInOrExists)
Review comment:
This change makes the rule `RewritePredicateSubquery`'s document
out-of-date. It also might be named as `RewriteCorrelatedPredicateSubquery`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
