Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3810#discussion_r22300274
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -333,9 +333,15 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
           new SparkException("DAGScheduler cannot be initialized due to 
%s".format(e.getMessage))
       }
     
    -  // start TaskScheduler after taskScheduler sets DAGScheduler reference 
in DAGScheduler's
    -  // constructor
    -  taskScheduler.start()
    +  if (conf.getBoolean("spark.scheduler.app.slowstart", false) && master == 
"yarn-client") {
    --- End diff --
    
    There is a new undocumented system property for this? why only client mode?
    My overall impression is that this adds different code paths and behaviors 
in different modes for little gain. I am not sure the description makes a case 
that it's significant enough to bother


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to