zsxwing commented on a change in pull request #24396: [SPARK-27496][CORE]Fatal
errors should also be sent back to the sender
URL: https://github.com/apache/spark/pull/24396#discussion_r276758550
##########
File path: core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala
##########
@@ -225,7 +225,15 @@ private[netty] class Dispatcher(nettyEnv: NettyRpcEnv,
numUsableCores: Int) exte
}
}
} catch {
- case ie: InterruptedException => // exit
+ case _: InterruptedException => // exit
+ case t: Throwable =>
+ try {
+ // Re-submit a MessageLoop so that Dispatcher will still work if
+ // UncaughtExceptionHandler decides to not kill JVM.
+ threadpool.execute(new MessageLoop)
+ } finally {
+ throw t
Review comment:
Yep. This is going to throw the fatal errors (non fatal errors have been
caught and should not reach here) to UncaughtExceptionHandler to let it decide
what to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
