squito commented on a change in pull request #24375: [SPARK-27474][CORE] avoid
retrying a task failed with CommitDeniedException many times
URL: https://github.com/apache/spark/pull/24375#discussion_r276793315
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala
##########
@@ -155,6 +155,12 @@ private[spark] class TaskResultGetter(sparkEnv: SparkEnv,
scheduler: TaskSchedul
}
}
+ def enqueuePartitionCompletionNotification(stageId: Int, partitionId: Int):
Unit = {
+ getTaskResultExecutor.execute(() => Utils.logUncaughtExceptions {
+ scheduler.handlePartitionCompleted(stageId, partitionId)
Review comment:
as we have to get a lock on the `TaskSchedulerImpl` anyway, is there any
advantage to this indirection here? Just avoiding aquiring the
`TaskSchedulerImpl` lock inside the DAGScheduler event loop? If so, that is
worth a comment here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
