Github user OopsOutOfMemory commented on the pull request:
https://github.com/apache/spark/pull/3823#issuecomment-68261526
Sorry, maybe here is a misunderstanding.
What I mean is to __`change` the `checking logic of properties file`__
instead of __`checking whether the SPARK_CONF_DIR is `user-specifc` or
`default` . But not to add an extra checking directory here .
Let me raise an example:
```
if [ ! -d "$SPARK_CONF_DIR" ]; then
export SPARK_CONF_DIR = $SPARK_HOME/conf
fi
DEFAULT_PROPERTIES_FILE="$SPARK_CONF_DIR/spark-defaults.conf"
XXX_PROPERTIES_FILE = "$SPARK_CONF_DIR/xxx.conf
```
To check conf directory is more reasonable, because the key point is the
`SPARK_CONF_DIR `. The original concern here is to change the `path` of
`SPARK_CONF_DIR` but not only `spark-default.conf`.
> analyse when use got some specific config wrong
We may add an extra warning for the `key configuration file` here. i.e If
`spark-deault.conf` is missing or changed to a user-specific dir under
conf_dir, we may raise an `warning log` to let user aware of this before
submitting.
Currently, I think both of the two solutions is ok! : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
