rdblue commented on a change in pull request #24410: [SPARK-24252][SQL] Move Table and TableCapabilities to catalyst module URL: https://github.com/apache/spark/pull/24410#discussion_r277027337
########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/Table.java ########## @@ -15,7 +15,7 @@ * limitations under the License. */ -package org.apache.spark.sql.sources.v2; +package org.apache.spark.sql.catalog.v2; Review comment: This is my fault. I should have insisted from the start that `Table` should be in the `catalog` package, but I didn't want a needless argument about it at the time. `Table` is part of the catalog API because it is what table catalogs pass back to Spark. That's why it was part of the original PR, #21306. This makes the catalog API self-contained, and the storage API is dependent on it. The two should not be inter-dependent. We should be able to update either one without affecting the other. But the purpose of this PR is not to block the table catalog API and other work while we debate organization. I'll close this PR and revert the package move in #24246. Then we can get that in without further code churn. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
