cloud-fan commented on a change in pull request #24437: [SPARK-27512][SQL]
Avoid to replace ',' in CSV's decimal type inference for backward compatibility
URL: https://github.com/apache/spark/pull/24437#discussion_r277316461
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchemaSuite.scala
##########
@@ -185,6 +185,8 @@ class CSVInferSchemaSuite extends SparkFunSuite with
SQLHelper {
assert(inferSchema.inferField(NullType, input) == expectedType)
}
- Seq("en-US", "ko-KR", "ru-RU", "de-DE").foreach(checkDecimalInfer(_,
DecimalType(7, 0)))
+ // input like '1,0' is inferred as strings for backward compatibility.
Review comment:
Sorry I may not know all the context, but doesn't `1,0` mean 2 int columns?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
