liu-sheng commented on a change in pull request #23846: [SPARK-26729][K8S] Make
image names under test configurable
URL: https://github.com/apache/spark/pull/23846#discussion_r277507929
##########
File path:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -119,4 +139,15 @@ then
properties=( ${properties[@]} -Dtest.exclude.tags=$EXCLUDE_TAGS )
fi
+BASE_IMAGE_NAME=${BASE_IMAGE_NAME:-spark}
+JVM_IMAGE_NAME=${JVM_IMAGE_NAME:-${BASE_IMAGE_NAME}}
+PYTHON_IMAGE_NAME=${PYTHON_IMAGE_NAME:-${BASE_IMAGE_NAME}-py}
+R_IMAGE_NAME=${R_IMAGE_NAME:-${R_IMAGE_NAME}-r}
+
+properties+=(
Review comment:
it seems this `roperties+=(...` can not work, I have added a echo statement
before the `mvn` command, it shows the `properties` didn't contain the image
properties, see following log message:
```
+ properties=(${properties[@]} -Dtest.exclude.tags=$EXCLUDE_TAGS)
+ BASE_IMAGE_NAME=spark
+ JVM_IMAGE_NAME=spark
+ PYTHON_IMAGE_NAME=spark-py
+ R_IMAGE_NAME=-r
+ properties+=(-Dspark.kubernetes.test.jvmImage=$JVM_IMAGE_NAME
-Dspark.kubernetes.test.pythonImage=$PYTHON_IMAGE_NAME
-Dspark.kubernetes.test.rImage=$R_IMAGE_NAME)
+ echo
-Dspark.kubernetes.test.sparkTgz=/home/zuul/src/github.com/liu-sheng/spark/spark-3.0.0-SNAPSHOT-bin-2.7.4.tgz
-Dspark.kubernetes.test.sparkTgz=/home/zuul/src/github.com/liu-sheng/spark/spark-3.0.0-SNAPSHOT-bin-2.7.4.tgz
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
