dongjoon-hyun commented on a change in pull request #24439: 
[SPARK-27544][PYTHON][TEST][BRANCH-2.4] Fix Python test script to work on 
Scala-2.12 build
URL: https://github.com/apache/spark/pull/24439#discussion_r277542759
 
 

 ##########
 File path: python/run-tests.py
 ##########
 @@ -59,9 +59,7 @@ def print_red(text):
 LOGGER = logging.getLogger()
 
 # Find out where the assembly jars are located.
-# Later, add back 2.12 to this list:
-# for scala in ["2.11", "2.12"]:
-for scala in ["2.11"]:
+for scala in ["2.11", "2.12"]:
     build_dir = os.path.join(SPARK_HOME, "assembly", "target", "scala-" + 
scala)
     if os.path.isdir(build_dir):
         SPARK_DIST_CLASSPATH = os.path.join(build_dir, "jars", "*")
 
 Review comment:
   @felixcheung . We assume that the Spark developers don't build both profiles 
without cleanup. This is a standard Spark way used since Spark 2.0.0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to