gaborgsomogyi commented on a change in pull request #24270:
[SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10
URL: https://github.com/apache/spark/pull/24270#discussion_r277564953
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaProducer.scala
##########
@@ -38,7 +38,7 @@ private[kafka010] object CachedKafkaProducer extends Logging
{
private lazy val cacheExpireTimeout: Long =
Option(SparkEnv.get).map(_.conf.getTimeAsMs(
- "spark.kafka.producer.cache.timeout",
+ PRODUCER_CACHE_TIMEOUT.key,
s"${defaultCacheExpireTimeout}ms")).getOrElse(defaultCacheExpireTimeout)
Review comment:
> No need for the getOrElse if the config has a default, and the default can
be removed.
`SparkEnv.get` can be `None` and such case the mentioned else handles the
situation.
> I think you need to call the 'get' method with the config object, rather
than its key
True.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
