rvesse commented on a change in pull request #23846: [SPARK-26729][K8S] Make
image names under test configurable
URL: https://github.com/apache/spark/pull/23846#discussion_r277574633
##########
File path:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -119,4 +139,15 @@ then
properties=( ${properties[@]} -Dtest.exclude.tags=$EXCLUDE_TAGS )
fi
+BASE_IMAGE_NAME=${BASE_IMAGE_NAME:-spark}
+JVM_IMAGE_NAME=${JVM_IMAGE_NAME:-${BASE_IMAGE_NAME}}
+PYTHON_IMAGE_NAME=${PYTHON_IMAGE_NAME:-${BASE_IMAGE_NAME}-py}
+R_IMAGE_NAME=${R_IMAGE_NAME:-${R_IMAGE_NAME}-r}
+
+properties+=(
Review comment:
@liu-sheng What did you echo? An `echo $properties` will only echo the
first item in the array, an `echo ${properties[@]}` echos the entire array. It
looks like you only echo'd the first item in the array
Note that you can invoke the script with `sh -x
dev/dev-run-integration-tests.sh` to get detailed Bash debug output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
