gaborgsomogyi commented on a change in pull request #24382: [SPARK-27330][SS]
support task abort in foreach writer
URL: https://github.com/apache/spark/pull/24382#discussion_r277601213
##########
File path: docs/structured-streaming-programming-guide.md
##########
@@ -2145,6 +2145,10 @@ streamingDatasetOfString.writeStream.foreach(
def close(errorOrNull: Throwable): Unit = {
// Close the connection
}
+
+ def abort(): Unit = {
+ // Close the connection, this method is optional
Review comment:
Since in the abort case there is no valid exception it's fine to use a
generic one.
If I understand it correctly you would like to use this generic exception
only. When the problem occurred during processing there is a valid and not
generic exception which represents value, consuming it and throwing it away is
bad direction (if my assumption is correct). Until now `close` may be called
several times because the API doesn't guarantee exactly-once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
