holdenk commented on a change in pull request #24426: [SPARK-26970][PYTHON][ML]
Add Spark ML interaction transformer to PySpark
URL: https://github.com/apache/spark/pull/24426#discussion_r277779584
##########
File path: python/pyspark/ml/feature.py
##########
@@ -1227,6 +1228,54 @@ def surrogateDF(self):
return self._call_java("surrogateDF")
+@inherit_doc
+class Interaction(JavaTransformer, HasInputCols, HasOutputCol, JavaMLReadable,
JavaMLWritable):
Review comment:
This is relatively minor, but since this implements `JavaMLReadable` &
`JavaMLWriteable` it might be reasonable to have a test for the read/write
either in the doc tests or in `tests.py` -- it would not have to be very
involved just taking model and roundtriping it write/read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
