httfighter commented on a change in pull request #24440: [SPARK-27545] [SQL]
Uncache table needs to delete the temporary view …
URL: https://github.com/apache/spark/pull/24440#discussion_r277991574
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -442,7 +442,11 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
override def uncacheTable(tableName: String): Unit = {
Review comment:
I have also considered this issue. Finally, I decided to it in
`uncacheTable` for two reasons.
1. `UncacheTableCommand` only uses `sparkSession.catalog.uncacheTable` to do
the operation of deleting the cache, and there is no other operation.
2. There are many other places that use `sparkSession.catalog.uncacheTable`
to implement the operation of `uncache table`. I think these places also need
to consider drop the view.
@viirya May I ask if these considerations are correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
