viirya commented on a change in pull request #24440: [SPARK-27545] [SQL]
Uncache table needs to delete the temporary view …
URL: https://github.com/apache/spark/pull/24440#discussion_r278005576
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -442,7 +442,11 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
override def uncacheTable(tableName: String): Unit = {
Review comment:
If the view isn't created when caching, I don't think it is good to remove
the view when uncaching. `CacheTableCommand` is the caching command creating
the view. I think it makes more sense to remove the view at
`UncacheTableCommand`. They are a pair of commands.
When you do deleting view at `uncacheTable`. For a view which isn't created
by `cache table as select`, uncaching it will delete it too? This sounds not
correct to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
