dongjoon-hyun commented on a change in pull request #24453: [SPARK-27551][SQL]
Improve error message of mismatched types for CASE statement
URL: https://github.com/apache/spark/pull/24453#discussion_r278402116
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ConditionalExpressionSuite.scala
##########
@@ -222,4 +223,29 @@ class ConditionalExpressionSuite extends SparkFunSuite
with ExpressionEvalHelper
CaseWhen(Seq((Literal.create(false, BooleanType), Literal(1))),
Literal(-1)).genCode(ctx)
assert(ctx.inlinedMutableStates.size == 1)
}
+
+ test("SPARK-27551: informative error message of mismatched types for case
when") {
+ val caseVal1 = Literal.create(
+ create_row(1),
+ StructType(Seq(StructField("x", IntegerType, false))))
+ val caseVal2 = Literal.create(
+ create_row(1),
+ StructType(Seq(StructField("y", IntegerType, false))))
+ val elseVal = Literal.create(
+ create_row(1),
+ StructType(Seq(StructField("z", IntegerType, false))))
+
+ val checkResult1 = CaseWhen(Seq((Literal.FalseLiteral, caseVal1),
+ (Literal.FalseLiteral, caseVal2))).checkInputDataTypes()
+ assert(checkResult1.isInstanceOf[TypeCheckResult.TypeCheckFailure])
+ assert(checkResult1.asInstanceOf[TypeCheckResult.TypeCheckFailure].message
+ .contains("CASE WHEN ... THEN struct<x:int> WHEN ... THEN struct<y:int>
END"))
Review comment:
Got it, @viirya . For `complex` types, this has a great benefit. Could you
add this example into the PR description, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
