Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/3771#discussion_r22352924
--- Diff:
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
@@ -153,6 +153,19 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments,
}
/**
+ * we should distinct the default final status between client and
cluster,
+ * because the SUCCEEDED status may cause the HA failed in client mode
and
+ * UNDEFINED may cause the error reporter in cluster when using sys.exit.
+ */
+ final def getDefaultFinalStatus() = {
--- End diff --
I assume we are hitting the logic on line 108 above in if (!finished) {...
I think that comment and code is based on the final status defaulting to
success. In the very least we should update that comment explaining what is
going to happen in client vs cluster mode. Since the DisassociatedEvent exits
with success for client mode I think making the default as undefined for client
mode is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
