uncleGen commented on a change in pull request #24278: [SPARK-27350][SQL] 
Support create table on data source V2
URL: https://github.com/apache/spark/pull/24278#discussion_r278525046
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
 ##########
 @@ -73,7 +91,35 @@ case class InsertIntoDataSourceDirCommand(
         logError(s"Failed to write to directory " + 
storage.locationUri.toString, ex)
         throw ex
     }
+  }
 
-    Seq.empty[Row]
+  def writeToV2Source(
+      sparkSession: SparkSession,
 
 Review comment:
   Don't strongly object here. Should we put this into a separate class like 
`InsertIntoDataSourceDirV2Command.scala`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to