HeartSaVioR commented on a change in pull request #24465: [SPARK-27575][CORE]
Yarn file-related confs should merge new value with existing value
URL: https://github.com/apache/spark/pull/24465#discussion_r278823270
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1381,7 +1391,8 @@ private case class OptionAssigner(
clusterManager: Int,
deployMode: Int,
clOption: String = null,
- confKey: String = null)
+ confKey: String = null,
+ mergeFn: Option[(String, String) => String] = None)
Review comment:
This needs to receive a function, since how to merge two values depends on
the semantic of the conf value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
