jaceklaskowski commented on a change in pull request #24327: [SPARK-27418][SQL]
Migrate Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r279136626
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -2979,37 +2979,40 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
}
test("SPARK-26709: OptimizeMetadataOnlyQuery does not handle empty records
correctly") {
- Seq(true, false).foreach { enableOptimizeMetadataOnlyQuery =>
- withSQLConf(SQLConf.OPTIMIZER_METADATA_ONLY.key ->
enableOptimizeMetadataOnlyQuery.toString) {
- withTable("t") {
- sql("CREATE TABLE t (col1 INT, p1 INT) USING PARQUET PARTITIONED BY
(p1)")
- sql("INSERT INTO TABLE t PARTITION (p1 = 5) SELECT ID FROM range(1,
1)")
- if (enableOptimizeMetadataOnlyQuery) {
- // The result is wrong if we enable the configuration.
- checkAnswer(sql("SELECT MAX(p1) FROM t"), Row(5))
- } else {
- checkAnswer(sql("SELECT MAX(p1) FROM t"), Row(null))
+ withSQLConf(SQLConf.USE_V1_SOURCE_READER_LIST.key -> "parquet") {
Review comment:
That could benefit from the object with `val name = parquet`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
