cloud-fan commented on a change in pull request #24442: [SPARK-27547][SQL] fix
DataFrame self-join problems
URL: https://github.com/apache/spark/pull/24442#discussion_r279227348
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1292,10 +1323,24 @@ class Dataset[T] private[sql](
colRegex(colName)
} else {
val expr = resolve(colName)
- Column(expr)
+ Column(addDataFrameIdToCol(expr))
Review comment:
Internally, I think we should never compare 2 attributes by `equal` not
`semanticEqual`.
Externally, if users rely on the equality of `Column`, yes this PR may break
it under some cases. If this matters, I can add a migration guide or update
`Column.equal`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
