mengxr commented on a change in pull request #24483: [SPARK-27588] Binary file
data source fails fast and doesn't attempt to read very large files
URL: https://github.com/apache/spark/pull/24483#discussion_r279360432
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormat.scala
##########
@@ -143,6 +151,16 @@ object BinaryFileFormat {
private[binaryfile] val CONTENT = "content"
private[binaryfile] val BINARY_FILE = "binaryFile"
+ private[binaryfile]
+ val CONF_TEST_BINARY_FILE_MAX_LENGTH =
"spark.test.data.source.binaryFile.maxLength"
+ /** An internal conf for testing max length. */
+ private[binaryfile] val TEST_BINARY_FILE_MAX_LENGTH = SQLConf
Review comment:
Even for internal conf used for tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
