pgandhi999 commented on issue #24459: [SPARK-24935][SQL][followup] support INIT -> UPDATE -> MERGE -> FINISH in Hive UDAF adapter URL: https://github.com/apache/spark/pull/24459#issuecomment-487704387 @cloud-fan The fix LGTM. Had a question though. After this change, do we still need to fix the initialization of aggregate buffer for SortBasedAggregate that https://github.com/apache/spark/pull/24149 originally addressed in the first commit https://github.com/apache/spark/pull/24149/commits/400db3d1dad4b92e0a70b89c2c687a42017d589b ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
