gatorsmile commented on a change in pull request #23841: [SPARK-26936][SQL] Fix
bug of insert overwrite local dir can not create temporary path in local
staging directory
URL: https://github.com/apache/spark/pull/23841#discussion_r279529958
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
##########
@@ -87,17 +87,17 @@ case class InsertIntoHiveDirCommand(
val targetPath = new Path(storage.locationUri.get)
val qualifiedPath = FileUtils.makeQualified(targetPath, hadoopConf)
- val writeToPath =
+ val (writeToPath: Path, fs: FileSystem) =
if (isLocal) {
val localFileSystem = FileSystem.getLocal(jobConf)
- localFileSystem.makeQualified(targetPath)
+ (localFileSystem.makeQualified(targetPath), localFileSystem)
} else {
- val dfs = qualifiedPath.getFileSystem(jobConf)
- if (!dfs.exists(qualifiedPath)) {
- dfs.mkdirs(qualifiedPath.getParent)
- }
- qualifiedPath
+ val dfs = qualifiedPath.getFileSystem(hadoopConf)
Review comment:
It sounds like it is safe to remove the variable jobConf and replace all the
usage in this file by hadoopConf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
