William1104 commented on a change in pull request #24221: [SPARK-27248][SQL]
refresh table should recreate cache with same cache name
URL: https://github.com/apache/spark/pull/24221#discussion_r279568088
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala
##########
@@ -299,6 +299,28 @@ private[sql] trait SQLTestUtilsBase
}
}
+ /**
+ * Drops cache `cacheName` after calling `f`.
+ */
+ protected def withCache(cacheNames: String*)(f: => Unit): Unit = {
Review comment:
Hi @gengliangwang, thanks for the review. However, it should be the cache
name instead of cached table name. It is because we may create a cache with a
name different from corresponding table name. They are not necessary the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
