dongjoon-hyun commented on a change in pull request #24442: [SPARK-27547][SQL]
fix DataFrame self-join problems
URL: https://github.com/apache/spark/pull/24442#discussion_r279580819
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -345,7 +345,8 @@ class Analyzer(
gid: Expression): Expression = {
expr transform {
case e: GroupingID =>
- if (e.groupByExprs.isEmpty || e.groupByExprs == groupByExprs) {
+ if (e.groupByExprs.isEmpty ||
+ e.groupByExprs.map(_.canonicalized) ==
groupByExprs.map(_.canonicalized)) {
Review comment:
According to the test result, only SparkR test case catch this. Could you
add a Scala test coverage in `sql/catalyst` module, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
