redsanket commented on a change in pull request #24498: [SPARK-27605] : Add new
column "Partition ID" to the tasks table in s…
URL: https://github.com/apache/spark/pull/24498#discussion_r279785619
##########
File path: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala
##########
@@ -304,7 +304,8 @@ private[spark] object JsonProtocol {
("Finish Time" -> taskInfo.finishTime) ~
("Failed" -> taskInfo.failed) ~
("Killed" -> taskInfo.killed) ~
- ("Accumulables" -> accumulablesToJson(taskInfo.accumulables))
+ ("Accumulables" -> accumulablesToJson(taskInfo.accumulables)) ~
+ ("Partition ID" -> taskInfo.partitionId)
Review comment:
nit: Not sure if it is ideal to maintain the order of the UI display like
Partition ID follows Task Index in the code as well maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
