vanzin commented on a change in pull request #24497:
[SPARK-11334][CORE][FOLLOWUP] Fix bug in Executor allocation manager in running
tasks calculation
URL: https://github.com/apache/spark/pull/24497#discussion_r279867050
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -696,6 +699,7 @@ private[spark] class ExecutorAllocationManager(
allocationManager.synchronized {
stageIdToNumTasks -= stageId
stageIdToNumRunningTask -= stageId
+ activeStageIdToStageAttemptId -= stageId
Review comment:
IIRC two stage attempts can actually be active at the same time, so this
would not be correct.
Maybe @squito remembers this better than I do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
