vanzin commented on a change in pull request #24499: [SPARK-25888][Core] Serve
local disk persisted blocks by the external service after releasing executor by
dynamic allocation
URL: https://github.com/apache/spark/pull/24499#discussion_r279881906
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -427,6 +446,15 @@ class BlockManagerMasterEndpoint(
locations.remove(blockManagerId)
}
+ if (storageLevel.useDisk && externalShuffleServiceEnabled) {
+ val externalShuffleServiceId =
externalShuffleServiceIdOnHost(blockManagerId)
Review comment:
Shouldn't you de-dupe this id object? Seems like for a large cached RDD
you'd end up with a lot of identical objects in memory... I remember seeing
similar logic to de-dupe the regular block manager ids somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
