mgaido91 commented on a change in pull request #24464: [SPARK-27439][SQL] Use
existing queryexecution in explaining Dataset
URL: https://github.com/apache/spark/pull/24464#discussion_r280039066
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -498,7 +498,8 @@ class Dataset[T] private[sql](
* @since 1.6.0
*/
def explain(extended: Boolean): Unit = {
- val explain = ExplainCommand(queryExecution.logical, extended = extended)
+ val explain = ExplainCommand(queryExecution.logical, extended = extended,
Review comment:
what about passing the `QueryExecution` as first parameter? IIUC, there is
only another place where `ExplainCommand` is created, so it is not going to be
a big change too and it is going to be cleaner IMO...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
