Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3844#discussion_r22372726
--- Diff:
external/mqtt/src/test/scala/org/apache/spark/streaming/mqtt/MQTTStreamSuite.scala
---
@@ -17,31 +17,58 @@
package org.apache.spark.streaming.mqtt
+import org.apache.spark.Logging
import org.scalatest.FunSuite
-
+import org.scalatest.concurrent.Eventually
+import scala.concurrent.duration._
import org.apache.spark.streaming.{Seconds, StreamingContext}
import org.apache.spark.storage.StorageLevel
import org.apache.spark.streaming.dstream.ReceiverInputDStream
+import org.eclipse.paho.client.mqttv3._
+import org.eclipse.paho.client.mqttv3.persist.MqttDefaultFilePersistence
-class MQTTStreamSuite extends FunSuite {
+abstract class MQTTStreamSuiteBase extends FunSuite with Eventually with
Logging {
val batchDuration = Seconds(1)
+ val master: String = "local[2]"
+ val framework: String = this.getClass.getSimpleName
+ val brokerUrl = "tcp://localhost:1883"
+ val topic = "def"
+
+ def publishData(sendMessage: String): Unit = {
+ try {
+ val persistence: MqttClientPersistence = new
MqttDefaultFilePersistence("/tmp")
+ val client: MqttClient = new MqttClient(brokerUrl,
MqttClient.generateClientId(), persistence)
+ client.connect()
+ val msgTopic: MqttTopic = client.getTopic(topic)
+ val message: MqttMessage = new
MqttMessage(String.valueOf(sendMessage).getBytes("utf-8"))
+ message.setQos(1)
+ message.setRetained(true)
+ msgTopic.publish(message)
+ println("Published data \ntopic: " + msgTopic.getName() +
"\nMessage: " + message)
+ client.disconnect()
+ } catch {
+ case e: MqttException => println("Exception Caught: " + e)
+ }
+ }
+}
- private val master: String = "local[2]"
-
- private val framework: String = this.getClass.getSimpleName
-
+class MQTTStreamSuite extends MQTTStreamSuiteBase {
test("mqtt input stream") {
val ssc = new StreamingContext(master, framework, batchDuration)
--- End diff --
This can cause the SparkContext to be not shutdown if there is an exception
in the unit test, causing a leaked SparkContext. Take a look at how it is done
in the KafkaStreamSuite with BeforeAndAfter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
