vanzin commented on a change in pull request #24499: [SPARK-25888][Core] Serve
local disk persisted blocks by the external service after releasing executor by
dynamic allocation
URL: https://github.com/apache/spark/pull/24499#discussion_r280622162
##########
File path:
core/src/test/scala/org/apache/spark/ExternalShuffleServiceSuite.scala
##########
@@ -92,4 +95,48 @@ class ExternalShuffleServiceSuite extends ShuffleSuite with
BeforeAndAfterAll {
}
e.getMessage should include ("Fetch failure will not retry stage due to
testing config")
}
+
+ test("SPARK-25888: using external shuffle service fetching disk persisted
blocks") {
+ sc = new SparkContext("local-cluster[1,1,1024]", "test", conf)
+ sc.env.blockManager.externalShuffleServiceEnabled should equal(true)
+ sc.env.blockManager.shuffleClient.getClass should
equal(classOf[ExternalShuffleClient])
+
+ // In a slow machine, one slave may register hundreds of milliseconds
ahead of the other one.
+ // If we don't wait for all slaves, it's possible that only one executor
runs all jobs. Then
Review comment:
This is a weird comment in a test that only requests one executor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
