Ngone51 commented on issue #24497: [SPARK-27630][CORE]Stage retry causes 
totalRunningTasks calculation to be negative
URL: https://github.com/apache/spark/pull/24497#issuecomment-489436811
 
 
   I agree with @squito 's opinion that running tasks in zombie TaskSet should 
also be counted for `ExecutorAllocationManager#totalRunningTasks`. Basing on 
this, I'm wondering that would it be ok if we just changing 
`stageIdToNumRunningTask` to `stageAttemptIdToNumRunningTask` ?  As 
`ExecutorAllocationManager` does not really care about the stage is active or 
not, but care about the running tasks across the stage attempts. @squito 
@cxzl25 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to