ConeyLiu commented on a change in pull request #24278: [SPARK-27350][SQL]
Support create table on data source V2
URL: https://github.com/apache/spark/pull/24278#discussion_r281099432
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Utils.scala
##########
@@ -35,10 +42,15 @@ private[sql] object DataSourceV2Utils extends Logging {
*
* @param source a [[TableProvider]] object
* @param conf the session conf
- * @return an immutable map that contains all the extracted and transformed
k/v pairs.
+ * @param extraOptions extra options will append to the extracted config
+ * @return an case insensitive immutable map that contains all the extracted
and transformed
+ * k/v pairs.
*/
- def extractSessionConfigs(source: TableProvider, conf: SQLConf): Map[String,
String] = {
- source match {
+ def extractSessionConfigs(
+ source: TableProvider,
+ conf: SQLConf,
+ extraOptions: Map[String, String]): CaseInsensitiveStringMap = {
+ val extracted = source match {
Review comment:
After calling `extractSessionConfigs`, we still need to merge the return
`extraOptions` and transfer it to `CaseInsensitiveStringMap`. This change is
just a simplify and I have updated the doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
