squito commented on a change in pull request #24485: [SPARK-27590][CORE] do not
consider skipped tasks when scheduling speculative tasks
URL: https://github.com/apache/spark/pull/24485#discussion_r281266180
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -1032,14 +1032,14 @@ private[spark] class TaskSetManager(
return false
}
var foundTasks = false
- val minFinishedForSpeculation = (speculationQuantile *
numTasks).floor.toInt
+ val minFinishedForSpeculation = math.max((speculationQuantile *
numTasks).floor.toInt, 1)
Review comment:
sorry I had actually meant to just compute this once in the constructor, eg.
around line 70
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
