turboFei commented on a change in pull request #24533: [SPARK-27637] For
nettyBlockTransferService, when exception occurred when fetching data, check
whether relative executor is alive before retry
URL: https://github.com/apache/spark/pull/24533#discussion_r281271873
##########
File path:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala
##########
@@ -117,11 +125,26 @@ private[spark] class NettyBlockTransferService(
}
}
+ val executorAliveChecker = new RetryingBlockFetcher.ExecutorAliveChecker
{
+ override def check(): Boolean = {
Review comment:
> how expensive is it?
It would be invoked only after the IOException corrupted, so the frequency
is not high.
For the driver, it only check whether an executorId is contained in a map
with O(1) constant time.
For the executor, its cost is a rpc request with driver, which is not
expensive .
@cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
