vanzin commented on a change in pull request #23560: [SPARK-26632][Core]
Separate Thread Configurations of Driver and Executor
URL: https://github.com/apache/spark/pull/23560#discussion_r281294628
##########
File path: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
##########
@@ -47,11 +48,15 @@ private[netty] class NettyRpcEnv(
host: String,
securityManager: SecurityManager,
numUsableCores: Int) extends RpcEnv(conf) with Logging {
+ val role = conf.get(EXECUTOR_ID).flatMap { id =>
+ if (id == SparkContext.DRIVER_IDENTIFIER) Some("driver") else
Some("executor")
+ }
private[netty] val transportConf = SparkTransportConf.fromSparkConf(
conf.clone.set(RPC_IO_NUM_CONNECTIONS_PER_PEER, 1),
"rpc",
- conf.get(RPC_IO_THREADS).getOrElse(numUsableCores))
+ conf.get(RPC_IO_THREADS).getOrElse(numUsableCores),
+ role)
Review comment:
This is fine (one arg per line).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
