maropu commented on a change in pull request #24516: [SPARK-27624][CORE] Fix
CalenderInterval to show an empty interval correctly
URL: https://github.com/apache/spark/pull/24516#discussion_r281461786
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -321,6 +321,10 @@ public String toString() {
appendUnit(sb, rest, "microsecond");
}
+ if (months == 0 && microseconds == 0) {
+ sb.append(" 0 microseconds");
Review comment:
nit: How about this?
```
} else if (months == 0) {
sb.append(" 0 microseconds");
}
```
In most cases, it seems microseconds is not zero, so I feel better to reduce
#branches.
LGTM except one minor comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
