pgandhi999 commented on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So… URL: https://github.com/apache/spark/pull/24149#issuecomment-490183883 @cloud-fan I do see your point but don't you still think, if fallback to SortBasedAggregate occurs, the initialize method for the new aggregate function should be invoked as I recall you said earlier: > Each aggregate function will create its own buffer. When we feed a buffer to a agg func, we are not asking the agg func to replace its own buffer with the new one, but we ask it to merge the new buffer to its own buffer. By the above logic, we still need to ensure that the respective aggregate buffer is initialized for the new set of aggregate functions. Or we should just use the same set of aggregate functions again for SortBasedAggregate. Correct me if I am wrong here.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
