attilapiros commented on a change in pull request #24499: [SPARK-25888][Core] Serve local disk persisted blocks by the external service after releasing executor by dynamic allocation URL: https://github.com/apache/spark/pull/24499#discussion_r281996828
########## File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala ########## @@ -48,6 +48,10 @@ class BlockManagerMasterEndpoint( // Mapping from block manager id to the block manager's information. private val blockManagerInfo = new mutable.HashMap[BlockManagerId, BlockManagerInfo] + // Mapping from external shuffle service block manager id to the block statuses. + private val blockStatusByShuffleService = + new mutable.HashMap[BlockManagerId, JHashMap[BlockId, BlockStatus]] Review comment: It is chosen because of consistency with the already existing solution for storing cached blocks: https://github.com/apache/spark/blob/cc7aea020a45adda9a464b3bb9300a6b35ec77ca/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala#L544-L546 I would prefer to have a type alias for `JHashMap[BlockId, BlockStatus]` then it would be a bit more self-explanatory. Would you prefer to have a comment here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
