zhengruifeng commented on a change in pull request #24555:
[SPARK-27656][GraphX][WIP] Safely register class for GraphX
URL: https://github.com/apache/spark/pull/24555#discussion_r282322229
##########
File path: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala
##########
@@ -213,6 +213,28 @@ class KryoSerializer(conf: SparkConf)
// We can't load those class directly in order to avoid unnecessary jar
dependencies.
// We load them safely, ignore it if the class not found.
Seq(
+ "org.apache.spark.graphx.Edge",
+ "org.apache.spark.graphx.Edge$mcB$sp",
Review comment:
Yes, they are needed if we want to register `Edge`, since type
specialization is used in
[https://github.com/apache/spark/blob/master/graphx/src/main/scala/org/apache/spark/graphx/Edge.scala#L32](url)
I had test this, if we do not reigster
`org.apache.spark.graphx.Edge$mcB$sp`, Edge[Boolean] will not be handled by
kryo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
