wangyum commented on a change in pull request #24391:
[SPARK-27402][SQL][test-hadoop3.2][test-maven] Fix hadoop-3.2 test
issue(except the hive-thriftserver module)
URL: https://github.com/apache/spark/pull/24391#discussion_r282815856
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcFilterSuite.scala
##########
@@ -76,15 +77,27 @@ class HiveOrcFilterSuite extends OrcTest with
TestHiveSingleton {
checkFilterPredicate(df, predicate, checkComparisonOperator)
}
- private def checkFilterPredicate
+ private def checkFilterPredicateWithDiffHiveVersion
(predicate: Predicate, stringExpr: String)
(implicit df: DataFrame): Unit = {
def checkLogicalOperator(filter: SearchArgument) = {
- assert(filter.toString == stringExpr)
+ if (HiveUtils.isHive23) {
+ assert(filter.toString == stringExpr.replace("\n", ", "))
Review comment:
No. It wont pass on Hive 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
