tgravescs commented on a change in pull request #24406: [SPARK-27024] Executor interface for cluster managers to support GPU and other resources URL: https://github.com/apache/spark/pull/24406#discussion_r283022389
########## File path: core/src/test/scala/org/apache/spark/ResourceDiscovererSuite.scala ########## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark + +import java.io.File +import java.nio.charset.StandardCharsets +import java.nio.file.{Files => JavaFiles} +import java.nio.file.attribute.PosixFilePermission._ +import java.util.EnumSet + +import com.google.common.io.Files + +import org.apache.spark.internal.config._ +import org.apache.spark.util.Utils + +class ResourceDiscovererSuite extends SparkFunSuite + with LocalSparkContext { + + test("Resource discoverer no resources") { + val sparkconf = new SparkConf + val resources = ResourceDiscoverer.findResources(sparkconf, false) + assert(resources.size === 0) + assert(resources.get("gpu").isEmpty, + "Should have a gpus entry that is empty") + } + + test("Resource discoverer multiple gpus") { + val sparkconf = new SparkConf + assume(!(Utils.isWindows)) + withTempDir { dir => + val file1 = new File(dir, "resourceDiscoverScript1") + // this is a bit ugly but do it the hardway to test out some formatting + Files.write("echo {\\\"name\\\":\\\"gpu\\\"," + + " \\\"addresses\\\":[\\\"0\\\",\\\"1\\\"]}", file1, StandardCharsets.UTF_8) + JavaFiles.setPosixFilePermissions(file1.toPath(), + EnumSet.of(OWNER_READ, OWNER_EXECUTE, OWNER_WRITE)) + sparkconf.set(SPARK_EXECUTOR_RESOURCE_PREFIX + "gpu" + + SPARK_RESOURCE_DISCOVERY_SCRIPT_POSTFIX, file1.getPath()) + val resources = ResourceDiscoverer.findResources(sparkconf, false) + val gpuValue = resources.get("gpu") + assert(gpuValue.nonEmpty, "Should have a gpu entry") + assert(gpuValue.get.name == "gpu", "name should be gpu") + assert(gpuValue.get.addresses.size == 2, "Should have 2 indexes") + assert(gpuValue.get.addresses.deep == Array("0", "1").deep, "should have 0,1 entries") + } + } + + // TODO Review comment: sorry left over, removed it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
