Github user brennonyork commented on the pull request:
https://github.com/apache/spark/pull/3867#issuecomment-68568947
Looks good to me. As an aside I remember @pwendell mentioning on the dev
mailing list that all PR's *should* have an associated JIRA ticket. Is there
one for this? If not, might be something you should add and link to. Not sure
if they'll be closing future PR's without associated JIRA's.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
