srowen commented on a change in pull request #24586:
[SPARK-27682][CORE][GRAPHX][MLLIB] Replace use of collections and methods that
will be removed in Scala 2.13 with work-alikes
URL: https://github.com/apache/spark/pull/24586#discussion_r283110804
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -506,17 +505,16 @@ private[spark] class DAGScheduler(
rdd: RDD[_]): HashSet[ShuffleDependency[_, _, _]] = {
val parents = new HashSet[ShuffleDependency[_, _, _]]
val visited = new HashSet[RDD[_]]
- val waitingForVisit = new ArrayStack[RDD[_]]
- waitingForVisit.push(rdd)
+ val waitingForVisit = ListBuffer[RDD[_]](rdd)
Review comment:
OK I think this 'optimization' does actually cause a problem. It's not happy
about the two unbound wildcard types involved in one expression now. Breaking
it back out ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
