Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3849#issuecomment-68581193
Maybe that test was flaky; let's see if it passes again (it'll retest since
I pushed a commit to fix a merge conflict).
I've updated this patch to not modify `attemptId` but to introduce
`attemptNumber` and deprecate `attemptId`. I think it will be confusing to
have `attemptId` have different behavior in different branches, especially
since it seems like functionality that might be nice to rely on when writing
certain types of regression tests. Since this patch doesn't change any
behavior, I'd like to backport it to maintenance branches so that we can rely
on it in test code. If we decide to do that, the committer should update the
MiMa exclusions on cherry-pick.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
